[FFmpeg-devel] [PATCH v3 01/25] avformat/movenc: mov_write_ftyp_tag: write the major brand as a compatible brand

[Michael Niedermayer]

On Mon, Sep 19, 2016 at 04:25:24PM +0300, Erkki Seppälä wrote:
> when the option "brand" is used. This allows custom brands to end up in
> the compatible brands as well.
> 
> Signed-off-by: Erkki Seppälä <erkki.seppala.ext at nokia.com>
> Signed-off-by: OZOPlayer <OZOPL at nokia.com>
> ---
>  libavformat/movenc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> index 525d103..571c2a7 100644
> --- a/libavformat/movenc.c
> +++ b/libavformat/movenc.c
> @@ -4210,6 +4210,8 @@ static int mov_write_ftyp_tag(AVIOContext *pb, AVFormatContext *s)
>  
>      avio_wb32(pb, minor);
>  
> +    if (mov->mode == MODE_MP4 && mov->major_brand)
> +        ffio_wfourcc(pb, mov->major_brand); /* write major brand as a compatible brand */

missing length check, this would be writing uninitialized bytes
if it was nt 4 bytes long

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161105/2c1d0416/attachment.sig>