[FFmpeg-devel] [PATCH v3 11/25] avformat/movenc: add the urim sample descriptor

Michael Niedermayer michael at niedermayer.cc
Sun Nov 6 00:32:38 EET 2016


On Mon, Sep 19, 2016 at 04:25:34PM +0300, Erkki Seppälä wrote:
> This also adds libavformat/movmeta that contains the meta data
> information. Actually the sample configuration data is performed with
> side packet data AV_PKT_DATA_TIMED_METADATA_INFO where the value is
> stored inside AVTimedMetadataInfo.
> 
> Signed-off-by: Erkki Seppälä <erkki.seppala.ext at nokia.com>
> Signed-off-by: OZOPlayer <OZOPL at nokia.com>
> ---
>  libavcodec/avcodec.h  | 16 ++++++++++
>  libavformat/isom.c    |  1 +
>  libavformat/movenc.c  | 83 ++++++++++++++++++++++++++++++++++++++++++++++++---
>  libavformat/movenc.h  |  1 +
>  libavformat/movmeta.h | 46 ++++++++++++++++++++++++++++
>  5 files changed, 143 insertions(+), 4 deletions(-)
>  create mode 100644 libavformat/movmeta.h
> 
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index 4219a9f..0079d22 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -1350,6 +1350,16 @@ typedef struct AVCPBProperties {
>   * @{
>   */
>  
> +typedef struct AVTimedMetadataInfo {
> +    char        meta_tag[4];    /**< 4cc describing this metadata box type */
> +    int         meta_length;    /**< length of data for the metadata type information */
> +
> +    char        conf_tag[4];    /**< configurationg box type 4cc, ie. 'conf' */
> +    int         conf_length;    /**< length of the data for the configuration box */
> +
> +    /** followed by meta_length bytes of meta data followed by conf_length bytes of conf data */
> +} AVTimedMetadataInfo;
> +
>  typedef struct AVTrackReferences {
>      int         next_tref_ofs;  /**< offset in bytes to the next AVTrackReferences or 0 if this is the last one*/
>      char        tag[4];         /**< 4cc used for describing this  */

> @@ -1546,6 +1556,12 @@ enum AVPacketSideDataType {
>      AV_PKT_DATA_TRACK_REFERENCES,
>  
>      /**
> +     * Configured the timed metadata parameters, such as the uri and
> +     * meta data configuration. The value is of type AVTimedMetadataInfo.
> +     */
> +    AV_PKT_DATA_TIMED_METADATA_INFO,
> +
> +    /**
>       * Assign alternate groups for tracks. An example of alternate
>       * groups would be audio tracks (or video tracks) that are
>       * alternative to each other. Each alternative track shares the

you cannot add things into the middle of the enum, that breaks ABI
even if you just added the entry afterwards this is not correct
2 patches may or may nt be applied at the same time

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161105/eec8b595/attachment.sig>


More information about the ffmpeg-devel mailing list