[FFmpeg-devel] [PATCH v3] avformat/flvenc: add add_keyframe_index option

Michael Niedermayer michael at niedermayer.cc
Mon Nov 7 17:48:29 EET 2016


On Mon, Nov 07, 2016 at 06:02:05PM +0800, Steven Liu wrote:
> Add keyframe index metadata
> Used to facilitate seeking; particularly for HTTP pseudo streaming.
>  1. read live streaming or file by sequence
>  2. if use add_keyframe_index option, add a mark flag at the position,
>     use to insert new context at the last step.
>  3. add the keyframes *offset* and *timestamp* into a list
>  4. if use add_keyframe_index option, shift the metadata data from
>     mark flag offset
>  5. insert the keyframes *offset* and *timestamp* from the list by
>     sequence
>  6. free the list
>  7. end.
> 
> Add FATE test case;
> 
> Reviewed-by: Lou Logan <lou at lrcd.com>
> Signed-off-by: Steven Liu <liuqi at gosun.com>
> ---
>  doc/muxers.texi                       |    3 +
>  libavformat/flvenc.c                  |  331 ++++++++++++++++++++++++++++++++-
>  tests/Makefile                        |    1 +
>  tests/fate-run.sh                     |    4 +
>  tests/fate/flvenc.mak                 |   11 +
>  tests/ref/fate/flv-add_keyframe_index |   12 ++
>  6 files changed, 352 insertions(+), 10 deletions(-)
>  create mode 100644 tests/fate/flvenc.mak
>  create mode 100644 tests/ref/fate/flv-add_keyframe_index

fate test fails on qemu arm:
@@ -4,9 +4,9 @@
 hasAudio=false
 hasMetadata=true
 canSeekToEnd=true
-datasize=633428
-videosize=633033
+datasize=629772
+videosize=629377
 audiosize=0
 lasttimestamp=20
 lastkeyframetimestamp=19
-lastkeyframelocation=601489
+lastkeyframelocation=597959
Test flv-add_keyframe_index failed. Look at tests/data/fate/flv-add_keyframe_index.err for details.
make: *** [fate-flv-add_keyframe_index] Error 1

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161107/e5b11ac3/attachment.sig>


More information about the ffmpeg-devel mailing list