[FFmpeg-devel] [PATCH 1/2] Move av_show_help_children() to avutil/opt

[Andreas Cadhalpun]

On 04.11.2016 21:16, Michael Niedermayer wrote:
> diff --git a/libavutil/opt.c b/libavutil/opt.c
> index cd16bd1..1b8dae2 100644
> --- a/libavutil/opt.c
> +++ b/libavutil/opt.c
> @@ -1992,3 +1992,15 @@ int av_opt_serialize(void *obj, int opt_flags, int flags, char **buffer,
>      av_bprint_finalize(&bprint, buffer);
>      return 0;
>  }
> +
> +void av_show_help_children(const AVClass *class, int flags)
> +{
> +    const AVClass *child = NULL;
> +    if (class->option) {
> +        av_opt_show2(&class, NULL, flags, 0);
> +        printf("\n");

The libraries must not use printf directly, because unlike av_log it
can't be intercepted by API users. This applies also to the second patch.

On 04.11.2016 21:16, Michael Niedermayer wrote:
> This patch-set is also required for moving ffserver into a separate
> repository as it too uses these functions and they otherwise would need to
> be duplicated.

I'm not sure moving ffserver to a separate repository is very useful.
Its problem is that it uses private functions, which has to be fixed anyway.
However, moving it to a separate repository makes it impossible to test it
with FATE in order to prevent regressions.

Best regards,
Andreas