[FFmpeg-devel] [PATCH 2/2] lavfi: make filter_frame non-recursive.

[Hendrik Leppkes]

On Sun, Nov 13, 2016 at 11:54 PM, Nicolas George <george at nsup.org> wrote:
>> As i said, what I'm mostly looking for is consistency across the codebase
>> and to reduce ifdeffery.
>
> For consistency, I would prefer removing the indirections where they
> already are and replace them with invisible fields.
>
> And I consider this kind of ifdeffery, short and isolated, to be a
> non-issue.
>
> And most of all, efficiency should be the primary concern. Aesthetics
> comes only second.

I disagree with that, this is generic utility code, not a tight
algorithm loop, where absolute efficiency is not necessarily required,
and disregarding code simplicity amd consistency will just harm in the
long-run.

>
>> That has proven to be problematic before, between merges adding fields at
>> the wrong offset by accident,
>
> IIRC, you are mistaken, we only had that kind of issue about public
> fields.

No, this happened in 3.1 with "private" fields in public headers (in
lavfi among other things), which is what sparked the discussion to get
rid of all these in the future, either by making them proper public if
appropriate, or hiding them entirely from the publics eye - and the
existing concept we have for that is *Internal contexts.

- Hendrik