[FFmpeg-devel] [PATCH] smacker: limit recursion depth of smacker_decode_bigtree

[Andreas Cadhalpun]

On 19.11.2016 16:13, Michael Niedermayer wrote:
> On Sat, Nov 19, 2016 at 02:29:35PM +0100, Andreas Cadhalpun wrote:
>> This fixes segmentation faults due to stack-overflow caused by too deep
>> recursion.
>>
>> Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
>> ---
>>  libavcodec/smacker.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> breaks fate
> 
> [smackvid @ 0x3586b80] size 31232 too large
> Input #0, smk, from 'fate/fate-suite//smacker/wetlogo.smk':
>   Duration: 00:00:07.10, start: 0.000000, bitrate: 815 kb/s
>     Stream #0:0: Video: smackvideo (SMK2 / 0x324B4D53), pal8, 320x200, 14.08 tbr, 14.08 tbn, 14.08 tbc
>     Stream #0:1: Audio: smackaudio (SMKA / 0x414B4D53), 22050 Hz, mono, u8
> [smackvid @ 0x358b860] size 31232 too large
> Stream mapping:
>   Stream #0:0 -> #0:0 (smackvideo (smackvid) -> rawvideo (native))
> Error while opening decoder for input stream #0:0 : Invalid data found when processing input
> make: *** [fate-smacker-video] Error 1

Then this has to be checked more directly, see attached patch.

Best regards,
Andreas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-smacker-limit-recursion-depth-of-smacker_decode_bigt.patch
Type: text/x-diff
Size: 2208 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161119/659538cb/attachment.patch>