[FFmpeg-devel] [PATCH 2/2] Add experimental demuxing support for FLAC in ISO BMFF (MP4).
James Almer
jamrial at gmail.com
Mon Nov 21 20:56:31 EET 2016
On 11/1/2016 8:23 PM, Matthew Gregan wrote:
> At 2016-11-01T18:07:07-0300, James Almer wrote:
>> > Just include libavcodec/flac.h which already defines it.
>> >
>> > With the above header you'll also be able to use the inline function
>> > flac_parse_block_header() for this. See flac and matroska demuxers.
>> >
>> > INVALIDDATA errors would ideally also throw an error message.
>> >
>> > Use ff_get_extradata(), which combines these two into a single function.
> Thanks for the feedback. Updated patch attached with these addressed.
>
>
> 0002-Add-experimental-demuxing-support-for-FLAC-in-ISO-BM.patch
>
>
> From 7f08d03c7c73105098e3c398f10e5127b17eb368 Mon Sep 17 00:00:00 2001
> From: Matthew Gregan <kinetik at flim.org>
> Date: Fri, 21 Oct 2016 16:10:43 +1300
> Subject: [PATCH 2/2] Add experimental demuxing support for FLAC in ISO BMFF
> (MP4).
>
> Based on the draft spec at https://git.xiph.org/?p=flac.git;a=blob;f=doc/isoflac.txt
>
> Signed-off-by: Matthew Gregan <kinetik at flim.org>
> ---
> libavformat/mov.c | 39 +++++++++++++++++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
Pushed, thanks!
More information about the ffmpeg-devel
mailing list