[FFmpeg-devel] libavcodec : add psd image file decoder

[Michael Niedermayer]

On Tue, Nov 22, 2016 at 12:15:16AM +0100, Martin Vignali wrote:
> Hello,
> 
> 2016-11-21 23:16 GMT+01:00 Moritz Barsnick <barsnick at gmx.net>:
> 
> > On Mon, Nov 21, 2016 at 21:44:55 +0100, Martin Vignali wrote:
> > > +        avpriv_request_sample(s->avctx, "ZIP without predictor
> > compression");
> > > +        return AVERROR_PATCHWELCOME;
> > > +        break;
> > > +    case 3:
> > > +        avpriv_request_sample(s->avctx, "ZIP with predictor
> > compression");
> > > +        return AVERROR_PATCHWELCOME;
> > > +        break;
> >
> > Are these the only two (detectable) unsupported features? I.e. all
> > other error messages are true errors, not "unsupported"?
> > <http://ffmpeg.org/mailman/listinfo/ffmpeg-devel>
> >
> 
> I think,  i use AVERROR_PATCHWELCOME, for each documented features, that
> the decoder does not support.
> Do you have a specific place where you think i return the wrong message ?
> 
> I mainly use this link, for the psd specification :
> https://www.adobe.com/devnet-apps/photoshop/fileformatashtml/
> 
> 
> @Rostislav :
> > I don't think you need the checks, it was pointed out that
> > ff_set_dimensions already does that.
> > Also IIRC lavc doesn't support widths or heights over 16384 anyway.
> 
> Andreas ask why i choose 30 000 for check widths/heights
> And the choice come from the Adobe documentation : "Supported range is 1 to
> 30,000."
> 
> But i doesn't know about the 16384 limit, in lavc. I wrongly suppose, it
> was int max

./ffmpeg -i matrixbench_mpeg2.mpg -vf scale=60000:16 -vcodec ffv1 test.nut
works fine

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161122/7ab51483/attachment.sig>