[FFmpeg-devel] [PATCH] configure: fail if sdl2 was requested but not found

Josh de Kock josh at itanimul.li
Wed Nov 23 00:43:33 EET 2016


On 22/11/2016 22:33, Andreas Cadhalpun wrote:
> On 22.11.2016 23:30, Carl Eugen Hoyos wrote:
>> 2016-11-22 23:15 GMT+01:00 Andreas Cadhalpun <andreas.cadhalpun at googlemail.com>:
>>
>>>  disabled sdl && disable sdl2
>>> +enabled sdl2 && sdl_requested=yes
>>
>> I consider this ugly
>
> That is very subjective.
>

This goes both ways.

>> and it makes sdl different to all other system libraries: Why?
>
> Because it avoids confusing users. And the checks for other system
> libraries should do this, too.
>

I see no real reason to add this, but neither a reason to block it 
either. I personally think that it should stay as-is, or all other 
system libraries should have the same behavior as well. Consistency is key.

-- 
Josh


More information about the ffmpeg-devel mailing list