[FFmpeg-devel] [PATCH] doc/t2h: add max-width to css.

Sun Oct 2 15:43:50 EEST 2016

On 02/10/2016 08:24, Nicolas George wrote:
> Le decadi 10 vendémiaire, an CCXXV, Josh de Kock a écrit :
>> Full width text is really difficult to read, this just makes it
>> slightly more legible on larger (widescreen) screens.
>>
>> Signed-off-by: Josh de Kock <josh at itanimul.li>
>> ---
>> See http://screenshotcomparison.com/comparison/186256 for a comparison of before/after.
>>
>>  doc/t2h.init | 2 +-
>>  doc/t2h.pm   | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/doc/t2h.init b/doc/t2h.init
>> index c41be2e..994e276 100644
>> --- a/doc/t2h.init
>> +++ b/doc/t2h.init
>> @@ -22,7 +22,7 @@ EOT
>>  my $TEMPLATE_HEADER2 = $ENV{"FFMPEG_HEADER2"} || <<EOT;
>>    </head>
>>    <body>
>> -    <div style="width: 95%; margin: auto">
>> +    <div style="width: 95%; max-width: 960px; margin: auto">
>>  EOT
>>
>>  my $TEMPLATE_FOOTER = $ENV{"FFMPEG_FOOTER"} || <<EOT;
>> diff --git a/doc/t2h.pm b/doc/t2h.pm
>> index 5efb2da..a3b7c6b 100644
>> --- a/doc/t2h.pm
>> +++ b/doc/t2h.pm
>> @@ -174,7 +174,7 @@ EOT
>>      <link rel="stylesheet" type="text/css" href="style.min.css">
>>    </head>
>>    <body>
>> -    <div style="width: 95%; margin: auto">
>> +    <div style="width: 95%; max-width: 960px; margin: auto">
>>        <h1>
>
> Text-related dimensions given in pixels seem bogus. Ems would be the correct
> unit for this kind of case.
>
> Regards,
>

Using max-width: 960px is common practice, and since pixels are 
generally not 1:1 but scaled with regards to DPI, rather than text-size 
it results in a more constant layout across environments.

Timothy's suggestion probably makes sense, I just haven't had time to 
update the patch.

-- 
Josh