[FFmpeg-devel] [PATCH] vf_fps: Don't flush a cached frame if it should have been dropped

[Derek Buitenhuis]

On 10/4/2016 9:58 PM, Michael Niedermayer wrote:
> breaks fate
> and the change to fate looks wrong, the last frame is lost
> make fate-filter-fps
> TEST    filter-fps
> --- ./tests/ref/fate/filter-fps 2016-10-04 14:46:19.642736770 +0200
> +++ tests/data/fate/filter-fps  2016-10-04 22:54:01.859353244 +0200
> @@ -84,4 +84,3 @@
>  0,         78,         78,        1,    30576, 0xa2fcd06f
>  0,         79,         79,        1,    30576, 0xa2fcd06f
>  0,         80,         80,        1,    30576, 0xa2fcd06f
> -0,         81,         81,        1,    30576, 0xd4150aad
> Test filter-fps failed. Look at tests/data/fate/filter-fps.err for details.

This "break" may actually be more correct output, but I am not familiar enough
with lavfi or vf_fps to say. Removing the last frame in case where it should have
been removed was the entire point of this patch.

Perhaps someone more familiar with the code here can comment? Nicholas, maybe?

- Derek