[FFmpeg-devel] [PATCH 1/3] Improve selftest coverage for libavutil library

[Michael Niedermayer]

On Mon, Oct 10, 2016 at 08:56:51PM -0700, Thomas Turner wrote:
> Code coverage for av_fifo_generic_peek(...) and av_fifo_grow(...) .
> ---
>  libavutil/tests/fifo2.c | 77 +++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 77 insertions(+)
>  create mode 100644 libavutil/tests/fifo2.c
> 
> diff --git a/libavutil/tests/fifo2.c b/libavutil/tests/fifo2.c
> new file mode 100644
> index 0000000..923feee
> --- /dev/null
> +++ b/libavutil/tests/fifo2.c

We generally put all tests for "something" into the same file
these could be put into fifo.c
[...]

> +    data_arr = (int32_t*)malloc(fifo_size);

the cast is unneeded in C

also please dont add code that is changed in the immedeatly next patch
that makes review difficult

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

You can kill me, but you cannot change the truth.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20161012/0ab02e94/attachment.sig>