[FFmpeg-devel] [PATCH] libopenjpegenc: recreate image data buffer after encoding frame

Michael Bradshaw mjbshaw at gmail.com
Thu Oct 13 04:36:32 EEST 2016


On Wed, Oct 12, 2016 at 8:45 AM, Andreas Cadhalpun <
andreas.cadhalpun at googlemail.com> wrote:

> On 12.10.2016 03:42, Michael Bradshaw wrote:
> > On Tue, Oct 11, 2016 at 9:57 AM, Andreas Cadhalpun <
> > andreas.cadhalpun at googlemail.com> wrote:
> >
> >> openjpeg 2 sets the data pointers of the image components to NULL,
> >> causing segfaults if the image is reused.
> >>
> >
> > I've never seen this issue.
>
> That's strange, as it happens practically always here (on Debian
> testing/sid).
>
> > Is there a particular version of OpenJPEG or
>
> The OpenJPEG version is 2.1.2, i.e. the latest.
>
> > reproduction steps available?
>
> For example:
> $ ffmpeg -f lavfi -i testsrc -c:v libopenjpeg -f null /dev/null


Thanks for that (and the link back to the OpenJPEG source). Well dang. I
think it would be better to change the patch to completely remove the image
member from LibOpenJPEGContext, and instead just create a local image (and
destroy it) for every call to libopenjpeg_encode_frame.


More information about the ffmpeg-devel mailing list