[FFmpeg-devel] [PATCHv3] mov: Evaluate the movie display matrix

Vittorio Giovara vittorio.giovara at gmail.com
Tue Oct 18 00:28:20 EEST 2016


On Thu, Oct 13, 2016 at 6:50 PM, Vittorio Giovara
<vittorio.giovara at gmail.com> wrote:
> This matrix needs to be applied after all others have (currently only
> display matrix from trak), but cannot be handled in movie box, since
> streams are not allocated yet. So store it in main context, and apply
> it when appropriate, that is after parsing the tkhd one.
>
> Signed-off-by: Vittorio Giovara <vittorio.giovara at gmail.com>
> ---
> Reworked second matrix handling so that it is always applied, which makes
> the code easier to read and test. Updated according reviews, rolled back
> a couple of points for the reasons explained in the thread.
>
> Needs a new sample to be uploaded to fate,
> https://www.dropbox.com/s/qfio4bjhkpz3p4o/displaymatrix.mov?dl=0,
> the previous one can be deleted.
>
> Cheers,
>     Vittorio
>
>  libavformat/isom.h                |  2 ++
>  libavformat/mov.c                 | 53 +++++++++++++++++++++++++++++++--------
>  tests/fate/mov.mak                |  6 ++++-
>  tests/ref/fate/mov-display-matrix | 10 ++++++++
>  4 files changed, 59 insertions(+), 12 deletions(-)
>  create mode 100644 tests/ref/fate/mov-display-matrix

Ping? Please cc me or i might miss replies.
Thanks
-- 
Vittorio


More information about the ffmpeg-devel mailing list