[FFmpeg-devel] [PATCH] avformat/matroskaenc: write DisplayWidth and DisplayHeight elements only if they differ from PixelWidth and PixelHeight

[James Almer]

On 10/20/2016 2:05 PM, Nicolas George wrote:
> Le nonidi 29 vendémiaire, an CCXXV, Dave Rice a écrit :
>> You could also make the storage simpler by considering whether or not to
>> write DisplayWidth and DisplayHeight independently. For instance:
>> PixelWidth=720
>> PixelHeight=480
>> DisplayWidth=640
>> DisplayHeight=480
>>
>> could be simplified to this (as DisplayHeight if unstored, defaults to PixelHeight)
>> PixelWidth=720
>> PixelHeight=480
>> DisplayWidth=640
> 
> Even apart from the drawbacks you expect, I do not think this
> micro-optimization is very interesting. Logically, width and height go
> together, using half a default value seems unnatural.
> 
> Regards,

I agree. Pushed as is.

Thanks.