[FFmpeg-devel] [PATCH 3/3] vf_colorspace: Add support for smpte 431/432 (dci/display p3) primaries

Ronald S. Bultje rsbultje at gmail.com
Sun Oct 30 15:18:18 EET 2016


Hi,

On Sun, Oct 30, 2016 at 3:07 AM, Vittorio Giovara <
vittorio.giovara at gmail.com> wrote:

> Signed-off-by: Vittorio Giovara <vittorio.giovara at gmail.com>
> ---
> I couldn't find any reference to the name of the whitepoint used for 431,
> so I came up with DCI, since it looks like it is only used there.
> Please CC.
> Vittorio
>
>  libavfilter/vf_colorspace.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/libavfilter/vf_colorspace.c b/libavfilter/vf_colorspace.c
> index 7e0bafa..4265aa1 100644
> --- a/libavfilter/vf_colorspace.c
> +++ b/libavfilter/vf_colorspace.c
> @@ -56,6 +56,7 @@ enum Colorspace {
>  enum Whitepoint {
>      WP_D65,
>      WP_C,
> +    WP_DCI,
>      WP_NB,
>  };
>
> @@ -268,6 +269,7 @@ static const struct TransferCharacteristics *
>  static const struct WhitepointCoefficients whitepoint_coefficients[WP_NB]
> = {
>      [WP_D65] = { 0.3127, 0.3290 },
>      [WP_C]   = { 0.3100, 0.3160 },
> +    [WP_DCI] = { 0.3140, 0.3510 },
>  };


Hmm... So, the wikipedia page https://en.wikipedia.org/wiki/DCI-P3 refers
to the two whitepoints here as DCI-P3 D65 and DCI-P3 Theater. Calling one
D65 and the other DCI seems confusing in that light (assuming the wikipedia
page is correct). I'd call it THEATER or DCI_P3_THEATER, to distinguish it
from DCI-P3 D65. Is that OK?

Ronald


More information about the ffmpeg-devel mailing list