[FFmpeg-devel] [PATCH v2 04/18] avformat/movenc: deal with AVMEDIA_TYPE_DATA by using AV_CODEC_ID_META

[Carl Eugen Hoyos]

Hi!

2016-09-06 13:13 GMT+02:00 Erkki Seppälä <erkki.seppala.ext at nokia.com>:
> (Cc'ing as it's been some time.)

Please don't.

> On 08/31/2016 04:42 PM, Carl Eugen Hoyos wrote:
>>
>> I meant "defaulting to an additional track in the output mov file if the
>> input file contains such a data track (instead of ignoring this track
>> of the input file by default)".
>
> So I looked into it and indeed the data tracks end up with the enabled
> flag enabled. If this affects anything is a bit unclear to me, perhaps in
> some players? It seems to me they would unlikely try to play something
> they don't know how to - in a worse case perhaps the can stop or crash.

Sorry, that is not what I meant (although it may or may not
be an issue).
I meant that for the same ffmpeg command line and the same
input file, I believe that with your patch, the output file (suddenly)
has one track more than before (because the data codec is now
listed in AVOutputFormat, the ffmpeg cli will try to add this track
if the input file provides such a codec).

Maybe this is wrong because the data codec does not produce
a new track if it is passed to the muxer?

Iirc, my question was equivalent to:
Can you just remove the additional ".data_codec=" lines or is
it intended that they are now default codecs?
(Or am I simply wrong and they either do not lead to a new
track and / or ffmpeg simply ignores them because it only fills
video, audio and subtitle tracks?)

Carl Eugen