[FFmpeg-devel] [PATCH] avdev: Add SDL2 output device

[Josh de Kock]

On 11/09/2016 20:00, Moritz Barsnick wrote:
> Nice, seeing how often this has been pitched in the past.
>
> On Sun, Sep 11, 2016 at 16:38:12 +0100, Josh de Kock wrote:
>> This actually seems to work now, it didn't in the past, so maybe SDL2
>> was patched or something changed in FFmpeg.
>
> Interesting...
>
>> + * Copyright (c) 2011 Stefano Sabatini
>
> Does this show the age of the patch, or is this from the original sdl1
> implementation?
>
I started with the SDL1 implementation then after a few failed attempts 
to convert it over I deleted everything except for the settings and the 
header, then rewrote everything, I've updated the header in the latest 
iteration.

>> +    { "window_fullscreen", "set SDL window fullscreen", OFFSET(window_fullscreen), AV_OPT_TYPE_INT, { .i64 = 0 }, INT_MIN, INT_MAX, AV_OPT_FLAG_ENCODING_PARAM },
>> +    { "window_borderless", "set SDL window border off", OFFSET(window_fullscreen), AV_OPT_TYPE_INT, { .i64 = 0 }, INT_MIN, INT_MAX, AV_OPT_FLAG_ENCODING_PARAM },
>
> a) These should be _BOOL nowadays.
Ok.
> b) There's a copy/paste error there, disabling window_borderless.
Thanks!

--
Josh