[FFmpeg-devel] [PATCH 1/2] lavf/mov: fix parsing QuickTime meta after the first track
rodger.combs at gmail.com
Tue Sep 13 05:02:25 EEST 2016
> On Sep 10, 2016, at 05:10, Michael Niedermayer <michael at niedermayer.cc> wrote:
> On Fri, Sep 09, 2016 at 08:06:39PM -0500, Rodger Combs wrote:
>> I'm not entirely sure why found_hdlr_mdta existed to begin with, so cc-ing
>> Tinglin Liu (who originally wrote the patch) and Derek Buitenhuis (who signed
>> off on it) hoping for some background. If these checks actually do have a
>> purpose, then the `type == MKTAG('m','d','t','a')` check should be moved
>> to before the `c->fc->nb_streams < 1` check instead of inside it.
>> libavformat/isom.h | 1 -
>> libavformat/mov.c | 10 +++-------
>> 2 files changed, 3 insertions(+), 8 deletions(-)
> This seems to change
> "handler_name : sound handler" to
> "handler_name : ilst handler"
> for http://samples.ffmpeg.org/MPEG-4/replaygain/sample.mp4
> is that intended ?
Hmm, this looks like a consequence of the `handler_name` key being provided in multiple places on the same track, but I'm not sure `handler_name` is ever meaningful to the consumer to begin with, so I'm not sure if this matters?
> Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> Modern terrorism, a quick summary: Need oil, start war with country that
> has oil, kill hundread thousand in war. Let country fall into chaos,
> be surprised about raise of fundamantalists. Drop more bombs, kill more
> people, be surprised about them taking revenge and drop even more bombs
> and strip your own citizens of their rights and freedoms. to be continued
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
More information about the ffmpeg-devel