[FFmpeg-devel] [PATCH v6 1/3] lavd: Add SDL2 output device

Carl Eugen Hoyos ceffmpeg at gmail.com
Wed Sep 14 19:17:17 EEST 2016


2016-09-11 23:14 GMT+02:00 Josh de Kock <josh at itanimul.li>:

> +    { AV_PIX_FMT_RGB24,  SDL_PIXELFORMAT_RGB888 },

> +    { AV_PIX_FMT_BGR24,  SDL_PIXELFORMAT_BGR888 },

Did you test them / why did you remove the comments that said
they do not work?

> +    { AV_PIX_FMT_RGB0,   SDL_PIXELFORMAT_RGBX8888 },
> +    { AV_PIX_FMT_BGR0,   SDL_PIXELFORMAT_BGRX8888 },
> +    { AV_PIX_FMT_ARGB,   SDL_PIXELFORMAT_ARGB8888 },
> +    { AV_PIX_FMT_RGBA,   SDL_PIXELFORMAT_RGBA8888 },
> +    { AV_PIX_FMT_ABGR,   SDL_PIXELFORMAT_ABGR8888 },
> +    { AV_PIX_FMT_BGRA,   SDL_PIXELFORMAT_BGRA8888 },

These are wrong afaict, I am happy to fix them after this gets
committed if you are less interested.

I believe this is a very useful patch, thank you!

Carl Eugen


More information about the ffmpeg-devel mailing list