[FFmpeg-devel] [PATCH] avformat/http: remove duplicate user-agent option
u at pkh.me
Thu Sep 15 17:40:18 EEST 2016
On Thu, Sep 15, 2016 at 10:34:37PM +0800, Steven Liu wrote:
> 2016-09-15 22:22 GMT+08:00 Carl Eugen Hoyos <ceffmpeg at gmail.com>:
> > 2016-09-15 16:04 GMT+02:00 Steven Liu <lingjiujianke at gmail.com>:
> > > double user-agent option, same option, remove one.
> > Looking at the documentation, the patch is not ok as-is.
> > I suggest to deprecate the option now, and to remove it after
> > the next release.
> > Carl Eugen
> Carl Eugen's mean is apply this patch after the next release?
You need to deprecate the option with at least the classic #ifdefery dance
(git grep FF_API for examples), and ideally by also printing a warning
when using the wrong option.
More information about the ffmpeg-devel