[FFmpeg-devel] [PATCH]lavf/movenc: Put correct display aspect ratio in ARES atom

Paul B Mahol onemda at gmail.com
Tue Sep 20 20:02:50 EEST 2016


On 9/20/16, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> 2016-09-20 18:47 GMT+02:00 Paul B Mahol <onemda at gmail.com>:
>> On 9/20/16, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>>> 2016-09-20 17:42 GMT+02:00 Paul B Mahol <onemda at gmail.com>:
>>>> On 9/20/16, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>>>>> 2016-09-20 17:26 GMT+02:00 Paul B Mahol <onemda at gmail.com>:
>>>>>> On 9/20/16, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>>>>>>> 2016-09-19 13:28 GMT+02:00 Carl Eugen Hoyos <cehoyos at ag.or.at>:
>>>>>>>> Hi!
>>>>>>>>
>>>>>>>> We read a display aspect ratio from ARES atom because of several
>>>>>>>> user-provided samples, I believe it makes sense to also write the
>>>>>>>> width value into the ares atom depending on the aspect ratio.
>>>>>>>
>>>>>>> Ping.
>>>>>>
>>>>>> What about height?
>>>>>
>>>>> I thought height is already set correctly, is that wrong?
>>>>
>>>> So, height is not rescaled, but width is?
>>>
>>> It is rescaled for interlaced video iirc.
>>>
>>>> This does not make sense.
>>>
>>> What do you suggest?
>>
>> Please stop sending incorrect patches.
>
> Please be slightly more constructive:
> How can I reproduce the issue you see with the patch I sent?

How do you have tested that this patch is correct?


More information about the ffmpeg-devel mailing list