[FFmpeg-devel] [PATCH] avcodec/mpegvideo_enc: fix memory leak

[Timo Rothenpieler]

On 9/25/2016 3:55 PM, Carl Eugen Hoyos wrote:
> 2016-09-25 15:47 GMT+02:00 Timo Rothenpieler <timo at rothenpieler.org>:
>> On 9/25/2016 3:44 PM, Carl Eugen Hoyos wrote:
>>> 2016-09-25 15:43 GMT+02:00 Timo Rothenpieler <timo at rothenpieler.org>:
>>>> When the input frames contain side data, it will accumulate
>>>> endlessly in the coded frame, as av_frame_copy_props will
>>>> append any new side data.
>>>
>>> But there is no leak, no?
>>> Is this related to ticket #5799?
>>
>> This fixes that ticket for me, yes.
> 
> Please mention this in the commit message.
> 

Added locally.

>> And without this, ffmpeg keeps using more and more memory.
>> So while the memory is eventually freed when the encoding is done
> 
> I believe this defines it as not being a leak.

What else would it be? I think speaking of a leak here is still valid.

> Thank you for fixing this, Carl Eugen