[FFmpeg-devel] [PATCH]lavf/utils: Do not overflow in update_initial_timestamps().

Michael Niedermayer michael at niedermayer.cc
Mon Sep 26 00:55:55 EEST 2016


On Sun, Sep 25, 2016 at 09:04:30PM +0200, Carl Eugen Hoyos wrote:
> 2016-09-25 20:59 GMT+02:00 Michael Niedermayer <michael at niedermayer.cc>:
> > On Sat, Sep 24, 2016 at 03:28:36PM +0200, Carl Eugen Hoyos wrote:
> >> Hi!
> >>
> >> Attached patch hopefully fixes ticket #5136.
> >>
> >> Please review, Carl Eugen
> >
> >>  utils.c |    4 +++-
> >>  1 file changed, 3 insertions(+), 1 deletion(-)
> >> 519f209901429efaf9dffec381290a6a83573deb
> >> 0001-lavf-utils-Do-not-overflow-in-update_initial_timesta.patch
> >> From 09a31f8f6584f0c97443fd6edc7fcf7142b6a6ff Mon Sep 17 00:00:00 2001
> >> From: Carl Eugen Hoyos <cehoyos at ag.or.at>
> >> Date: Sat, 24 Sep 2016 15:26:21 +0200
> >> Subject: [PATCH] lavf/utils: Do not overflow in
> >> update_initial_timestamps().
> >>
> >> Fixes ticket #5136.
> >> ---
> >>  libavformat/utils.c |    4 +++-
> >>  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > probably ok
> > it might be ultimately easier to reject demuxer output that has
> > timestamps close to INT64 MAX/MIN instead of protecting all
> > computations one by one though
> 
> I don't disagree but I am probably unable to improve the patch.
> Do you want me to apply?

ive posted an alternative

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20160925/67a1aa23/attachment.sig>


More information about the ffmpeg-devel mailing list