[FFmpeg-devel] [PATCH]lavf/riffenc: Always write unexpected channel_mask

Tobias Rapp t.rapp at noa-archive.com
Tue Sep 27 10:38:01 EEST 2016


On 27.09.2016 09:02, Carl Eugen Hoyos wrote:
> 2016-09-27 8:49 GMT+02:00 Tobias Rapp <t.rapp at noa-archive.com>:
>> On 26.09.2016 12:39, Carl Eugen Hoyos wrote:
>
>>> Attached patch allows to write arbitrary (mono) channel_masks
>>> even for 16bit 48kHz pcm audio.
>>
>> As far as I understand this patch is in response to
>> https://ffmpeg.org/pipermail/ffmpeg-user/2016-September/033757.html
>> but in my opinion it doesn't match Robert's use-case.
>
> Where do I claim this?

It was how I interpreted the "just sent a patch" in 
https://ffmpeg.org/pipermail/ffmpeg-user/2016-September/033756.html .

> Do you believe the patch is wrong or does something
> unexpected?

The patch looks fine, although I haven't actually tested it.

>> Instead the "-channel_layout 0" input option should be fixed
>
> Please do send a patch!

Some time ago I tried to work on it but it turned out to be quite 
difficult especially when adding some audio filters (amerge? pan?) to 
the pipeline. So finally I refrained from doing it. Maybe I will try 
again if I find some time.

Regards,
Tobias



More information about the ffmpeg-devel mailing list