[FFmpeg-devel] [PATCH] frame_thread_encoder: make task indexing deterministic.

Michael Niedermayer michael at niedermayer.cc
Tue Apr 4 00:13:52 EEST 2017


On Sun, Apr 02, 2017 at 07:30:00AM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Sat, Apr 1, 2017 at 8:19 PM, Michael Niedermayer <michael at niedermayer.cc>
> wrote:
> 
> > Supporting changing delay and number of threads at runtime was a
> > big factor in the design of the frame thread encoder. Its something
> > i cared about, so i am not to positive towards patches removing that.
> 
> 
> It introduced a bug. I fixed it. Please accept the fix or fix it yourself
> differently. Don't advocate keeping a bug in our tree.

I would but iam not able to reproduce this warning with
gcc-6 (Ubuntu 6.2.0-3ubuntu11~12.04) 6.2.0 20160901

please try to move the finished_task_mutex lock up so it covers
the part of the check that needs it

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Never trust a computer, one day, it may think you are the virus. -- Compn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170403/052db85a/attachment.sig>


More information about the ffmpeg-devel mailing list