[FFmpeg-devel] [PATCH] avutil/internal: Do not enable CHECKED with DEBUG

[Michael Niedermayer]

On Fri, Apr 07, 2017 at 12:58:50PM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Fri, Apr 7, 2017 at 7:49 AM, Michael Niedermayer <michael at niedermayer.cc>
> wrote:
> 
> > This avoids potential undefined behavior in debug mode while still allowing
> > developers which want to check for potential additional overflows to do so
> > by manually enabling this.
> >
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavutil/internal.h | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/libavutil/internal.h b/libavutil/internal.h
> > index 7780a9a791..70ae37f859 100644
> > --- a/libavutil/internal.h
> > +++ b/libavutil/internal.h
> > @@ -30,9 +30,8 @@
> >  #    define NDEBUG
> >  #endif
> >
> > -#if defined(DEBUG) && !defined(CHECKED)
> > -#    define CHECKED
> > -#endif
> > +// This can be enabld to allow detection of additional integer overflows
> > with ubsan
> > +//#define CHECKED
> 
> 
> s/enabld/enabled/.

changed

applied

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170411/51eb7e48/attachment.sig>