[FFmpeg-devel] [PATCH v2] avformat/hlsenc: support fmp4 single file mode

[Steven Liu]

2017-08-04 20:49 GMT+08:00 Derek Buitenhuis <derek.buitenhuis at gmail.com>:
> On 8/1/2017 4:57 PM, Steven Liu wrote:
>> add byterange mode of the hls fmp4
>>
>> Signed-off-by: Steven Liu <lq at onvideo.cn>
>> ---
>>  libavformat/hlsenc.c | 83 +++++++++++++++++++++++++++++++++-------------------
>>  1 file changed, 53 insertions(+), 30 deletions(-)
>
> [...]
>
>> +        if (hls->max_seg_size > 0) {
>> +            av_log(s, AV_LOG_WARNING, "Have not support multiple fmp4 byterange mode file in hls yet now\n");
>> +            return AVERROR_PATCHWELCOME;
>> +        }
>
> Not entirely sure what this message is trying to say?
>
> Is this accurate: "Multi-file byterange moe is currently unsupported in the HLS muxer." ?
Ok, use your suggestion,
>
>> -    int byterange_mode = (hls->flags & HLS_SINGLE_FILE) || (hls->max_seg_size > 0);
>> +    int byterange_mode = ((hls->flags & HLS_SINGLE_FILE) || (hls->max_seg_size > 0));
>
> Doesn't change anything, as far as I can tell?
reserve it for wait the specification :)
>
> Rest is OK, I think.
>
> - Derek
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

adopt suggestion and applied the patch.

Thanks