[FFmpeg-devel] [PATCHv3 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

Jorge Ramirez jorge.ramirez-ortiz at linaro.org
Tue Aug 8 01:08:05 EEST 2017


On 08/08/2017 12:01 AM, Mark Thompson wrote:
>> great, thanks for that.
>> The issue I have is that the V4L2 driver I am using to test - yes this needs to be detected by the decoder- has not implemented the feature yet. Will keep it in mind before sending the last series of the patchset.
> Are they actually expecting the user to parse the stream externally to detect this case?  That wouldn't be too horrible to implement if many drivers are likely to have this problem - we already do essentially the same thing in the QSV decoder - see the parser use at<http://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavcodec/qsvdec.c;h=c00817f1d93e533c75c186b3477bc83a78822aa9;hb=HEAD#l459>.

the detection if I understood it correctly is handled and flagged by the 
hardware codec (the v4l2 driver) and the user (ie ffmpeg) is then 
notified and need to do some corrections.

But yes, I need to look this in detail (will not be in the next v4 
patchset, probably in v5)

>
>> also, I have rewritten the patchset to add clarity and clean some of the sedimentation from testing/hacking. is it ok with you if I post v4 now? it will simplify the discussion - the driver now much easier to follow.
> Sure.  I'll go through it again within a few days.

thanks a lot for your help on this.

>
> - Mark



More information about the ffmpeg-devel mailing list