[FFmpeg-devel] [PATCH 11/14] lavfi/vf_paletteuse: convert to framesync2.

Clément Bœsch u at pkh.me
Thu Aug 10 10:32:53 EEST 2017


On Thu, Aug 10, 2017 at 09:13:13AM +0200, Nicolas George wrote:
> Le tridi 23 thermidor, an CCXXV, Clement Boesch a écrit :
> > > -        .needs_writable = 1, // for error diffusal dithering
> > why?
> 
> It was not needed in the first place: IIRC, dualinput always returns a
> writable main frame. And the new implementation does, I am sure of it.
> 

But unless it's API documented, that's implementation specific. I'd prefer
if you keep that as a safe guard. It also has a documentation purpose. If
the frame is already writable it will be a noop.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170810/d99a5aba/attachment.sig>


More information about the ffmpeg-devel mailing list