[FFmpeg-devel] [PATCHv6 4/4] libavcodec: v4l2: add support for v4l2 mem2mem codecs

Jorge Ramirez jorge.ramirez-ortiz at linaro.org
Sun Aug 27 19:27:35 EEST 2017


On 08/25/2017 05:35 PM, wm4 wrote:
>> +#define WIDTH(__ctx, __fmt) \
>> +    (V4L2_TYPE_IS_MULTIPLANAR((__ctx)->type) ? __fmt.fmt.pix_mp.width : __fmt.fmt.pix.width)
>> +
>> +#define HEIGHT(__ctx, __fmt) \
>> +    (V4L2_TYPE_IS_MULTIPLANAR((__ctx)->type) ? __fmt.fmt.pix_mp.height : __fmt.fmt.pix.height)
> These names are a bit generic. Also, identifiers starting with __ are
> always implementation reserved (i.e. using them undefined behavior).
> You're forgetting to quote the __fmt macro parameter too.
>

ok, will just do inline functions instead. I shouldnt have done a macro...


More information about the ffmpeg-devel mailing list