[FFmpeg-devel] [PATCH] libavformat/dv : read dv audio as BE

[Michael Niedermayer]

On Wed, Aug 30, 2017 at 02:27:36PM +0300, Александр Слободенюк wrote:
> #include "libavutil/bswap.h" was not necessary for the compilation.
> 
> > I'm  really  sorry for the waste of your time... very shameful, that I
> > didn't mind to run fate first..
> 
> > The patch had 2 different bugs at the same time:
> > -  samples  were  restricted  to  one  byte  being taken from uint8_t
> > pointer
> > - 0x8000 magic was platform-related
> 
> > Sending the fixed version.
> 
> > P.S.  On  my system (bash subsystem for Windows 10) ffmpeg works fine,
> > but fate breaks on tests/data/fate/seek-extra-mp4
> 
> >> 2017-08-29 11:31 GMT+02:00 Александр Слободенюк
> >> <alexander.slobodeniuk at bramtech.ru>:
> >>> sending patch with bumped micro version.
> 
> >> Your patch breaks fate, this has to be fixed in the same commit.
> 
> >> Carl Eugen
> >> _______________________________________________
> >> ffmpeg-devel mailing list
> >> ffmpeg-devel at ffmpeg.org
> >> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> 
> 
> 
> 
> 
> -- 
> С уважением,
>  Александр                          mailto:alexander.slobodeniuk at bramtech.ru

>  dv.c      |   30 ++++++++++--------------------
>  version.h |    2 +-
>  2 files changed, 11 insertions(+), 21 deletions(-)
> e7b65efa7f8bea00355ff8754028579e9e39f66b  0001-libavformat-dv-read-dv-audio-as-BE.patch
> From 238c53030e9c5420a431df469f67a8e6c968abfd Mon Sep 17 00:00:00 2001
> From: Aleksandr Slobodeniuk <alenuke at yandex.ru>
> Date: Fri, 25 Aug 2017 17:02:18 +0300
> Subject: [PATCH] libavformat/dv : read dv audio as BE

this breaks stream copy:
./ffmpeg -i ~/tickets/1042/submarine.dv -acodec copy -vcodec copy file.dv
the sample file seems to be at
http://www.mediafire.com/file/8agcdgs2f9kqlbi/submarine.dv

[dv @ 0x2842d80] Can't initialize DV format!
Make sure that you supply exactly two streams:
     video: 25fps or 29.97fps, audio: 2ch/48|44|32kHz/PCM
     (50Mbps allows an optional second audio stream)
Could not write header for output file #0 (incorrect codec parameters ?): Operation not permitted

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170831/aac268e0/attachment.sig>