[FFmpeg-devel] [PATCH][RFC] avutil/reverse: make ff_reverse shared

Hendrik Leppkes h.leppkes at gmail.com
Fri Dec 1 10:49:14 EET 2017

On Fri, Dec 1, 2017 at 9:42 AM, Nicolas George <george at nsup.org> wrote:
> James Almer (2017-11-30):
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>> Pros:
>> Removes duplicate arrays and ugly c file including c files
>> Cons:
>> Makes the array in libavutil effectively part of the ABI.
>> Might not be worth doing for 256 bytes
>> Something like this was probably sent before, so i guess it
>> will be rejected again.
> I think it is worse than that: the opposite was done on purpose.
> I believe the rationale was that shared data object do not work
> correctly with shared libraries on windows.

That problem was fixed recently.

But in any case,  this creates a lot of noise for very marginal gains,
not sure its really worth it.

- Hendrik

More information about the ffmpeg-devel mailing list