[FFmpeg-devel] [PATCH] avfilter/vf_stereo3d: implement auto detection by using frame side data
michael at niedermayer.cc
Fri Dec 1 21:08:27 EET 2017
On Fri, Dec 01, 2017 at 07:23:00PM +0100, Nicolas George wrote:
> Michael Niedermayer (2017-12-01):
> > As the one who tried implementing changing frame parameters like
> > dimension long time ago, the only real problem i encountered was
> > bikeshedding, i dont rememer a technical problem.
> "not easy" != "tremendously hard". I said it would not be easy, i.e. it
> will require work and careful testing, but it is doable.
> But what you did was wrong, too simple, and results in our libraries
> outputting inconsistent data.
Do you think this comment will fix any issue or improve anything ?
First i do not even know what you speak of exactly and as this is
supposedly about code i wrote, i doubt others will have a better idea.
And there is possibly a difference in goals. Reinitializing filters
would loose filter state, so avoiding reinit unless really needed was
a big goal. Last but not least what i had envissioned is just in my head,
i never implemeted it. (the bikeshedding made me loose
interrest back then as i already mentioned) what is in git is a small
part of it, that alone certainly is not that great.
and "too simple" yes my vission of this was and is simple
> No time to say more today.
> Nicolas George
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 181 bytes
Desc: Digital signature
More information about the ffmpeg-devel