[FFmpeg-devel] [ogg] Respect AVERROR codes returned by ogg header parsing.
michael at niedermayer.cc
Sat Dec 2 20:06:40 EET 2017
On Fri, Dec 01, 2017 at 11:16:37AM -0800, Dale Curtis wrote:
> On Thu, Nov 30, 2017 at 5:49 PM, Michael Niedermayer <michael at niedermayer.cc
> > wrote:
> > I dont see anything really wrong with the file
> For kicks, I tried running it through oggz-validate, but it doesn't know
> how to handle ogm. Which TIL, is distinct from ogv.
> > it seems what happens is that theres a data packet in one stream that
> > preceeds the headers on the other streams, technically that data packet
> > likely contains the video headers so its kind of a header too.
> > The demuxer stops header parsing prematurly due to this.
> > from there on it gets confused reading the same header twice
> > while it determines the duration of the file which triggers the error
> > There are a few differnt ways to fix this, iam not sure which is the
> > simplest but i dont think the demuxer should fail in this case
> Applying a workaround similar to what you did here works:
> I.e. condition AVERROR_INVALIDATA based on priv->vp being incomplete here:
> WDYT? Here's a patch to do this and fail on AVERROR w/o the AV_EF_EXPLODE
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
"You are 36 times more likely to die in a bathtub than at the hands of a
terrorist. Also, you are 2.5 times more likely to become a president and
2 times more likely to become an astronaut, than to die in a terrorist
attack." -- Thoughty2
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 181 bytes
Desc: Digital signature
More information about the ffmpeg-devel