[FFmpeg-devel] avfilter/x86/vf_threshold : add SSE4 and AVX2 for threshold 16

James Darnley james.darnley at gmail.com
Sun Dec 3 22:15:21 EET 2017


On 2017-12-03 19:30, Martin Vignali wrote:
>  libavfilter/x86/vf_threshold.asm    | 19 ++++++++++++++-----
>  libavfilter/x86/vf_threshold_init.c | 34 ++++++++++++++++++++--------------
>  2 files changed, 34 insertions(+), 19 deletions(-)
> 
> diff --git a/libavfilter/x86/vf_threshold.asm b/libavfilter/x86/vf_threshold.asm
> index fb008c376a..7b929c6bd2 100644
> --- a/libavfilter/x86/vf_threshold.asm
> +++ b/libavfilter/x86/vf_threshold.asm
> @@ -27,14 +27,21 @@
>  SECTION_RODATA
>  
>  pb_128: times 16 db 128
> +pb_128_0 : times 16 dw 32768

No.  Please use db and the values you want.

I assume this is supposed to be "times 8 db 0, 128".  If these are
supposed to be word values then the constant should be named "packed
word".  If one were to reuse an existing constant for different word
sizes then it would be acceptable.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 603 bytes
Desc: OpenPGP digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171203/6bbb1d49/attachment.sig>


More information about the ffmpeg-devel mailing list