[FFmpeg-devel] [PATCH] tests/fate/mov: Disable fate-mov-invalid-elst-entry-count, the test does not work reliable currently

Michael Niedermayer michael at niedermayer.cc
Tue Dec 5 21:06:04 EET 2017

On Tue, Dec 05, 2017 at 01:54:27PM +0000, Derek Buitenhuis wrote:
> On 12/5/2017 12:38 AM, Michael Niedermayer wrote:
> > Noone is known to work on fixing this, so it should be disabled
> > 
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  tests/fate/mov.mak | 1 -
> >  1 file changed, 1 deletion(-)
> *NAK*
> Disabling failing tests entirely defeats the point of having test!

> The commit that broke it should be reverted until the author
> of that commit can explain why it changed, or fix it.

The commit that added the test was the one that broke fate. It never
So this "sort of" reverts what caused the issue.

Ill make this more clear in the commit message in case you otherwise
agree to the change ?

I can also exactly revert
the commit that added the test if thats preferred?

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171205/7a601527/attachment.sig>

More information about the ffmpeg-devel mailing list