[FFmpeg-devel] [PATCH] libvmaf: exit gracefully if the library fails.

Carl Eugen Hoyos ceffmpeg at gmail.com
Sun Dec 10 15:53:42 EET 2017


2017-12-09 2:35 GMT+01:00 Ronald S. Bultje <rsbultje at gmail.com>:
> Fixes trac issue #6884 and Netflix/vmaf issue #124.

> -    s->vmaf_score = compute_vmaf(format, s->width, s->height, read_frame, s,
> -                                 s->model_path, s->log_path, s->log_fmt, 0, 0,
> -                                 s->enable_transform, s->phone_model, s->psnr,
> -                                 s->ssim, s->ms_ssim, s->pool);
> +    s->error = compute_vmaf(&s->vmaf_score, format, s->width, s->height,
> +                            read_frame, s, s->model_path, s->log_path,
> +                            s->log_fmt, 0, 0, s->enable_transform,
> +                            s->phone_model, s->psnr, s->ssim,
> +                            s->ms_ssim, s->pool);

Sorry if I miss something:
This looks completely broken to me, how can the same function
of the same external library have two different amounts of
arguments (in C)?

Carl Eugen


More information about the ffmpeg-devel mailing list