[FFmpeg-devel] [PATCH] lavf/mp3dec: fix mp3 file probe fail
nfxjfg at googlemail.com
Mon Dec 11 12:43:30 EET 2017
On Fri, 8 Dec 2017 18:51:52 +0100
Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
> 2017-12-08 18:45 GMT+01:00 Tiejun.Peng <tiejun.peng at foxmail.com>:
> > i agree with you. too much experience value in condition of Judgement like this:
> > "else if(max_frames>=4 && max_frames >= p->buf_size/10000)".
> > why it is the value ? it is hard to known.
> > maybe the work of cleaned up need a few days, so i just repair of the probe.
> Please be careful:
> As you already know, this probe function is the result of many
> user reports, many tests and turning many knobs. You cannot
> "repair" it (easily).
> If you know of any false positives of the current probe function,
> please report them!
It plays ELF files as mp3.
You've been ignoring this issue, though.
This probe function is really pretty bad.
More information about the ffmpeg-devel