[FFmpeg-devel] [PATCH] lavf/mov: atom box parsing returneofcause play fail
tiejun.peng at foxmail.com
Mon Dec 11 14:37:43 EET 2017
yes, it is.
maybe we should add every stream's status and the whole file status can't be fail only by one of streams.
but the modification will be too much and the effect is extensive.
------------------ Original ------------------
From: "Michael Niedermayer";<michael at niedermayer.cc>;
Send time: Saturday, Dec 9, 2017 3:36 AM
To: "FFmpeg development discussions and patches"<ffmpeg-devel at ffmpeg.org>;
Subject: Re: [FFmpeg-devel] [PATCH] lavf/mov: atom box parsing returneofcause play fail
On Sat, Dec 09, 2017 at 12:06:47AM +0800, Tiejun.Peng wrote: > yes, i have checked this case and i have done a lot of tests with .mp4 file and fate Please correct me if iam wrong there are many different atoms/boxes and many functions parsing them If any of these return EOF, it has previously been consideered an error now it can be handled as not an error. Noone has reviewed most of this code to be safe after the change. It doesnt crash in fate or with some valid mp4 files When a parsing function hits EOF it may return EOF. This can occur in the middle of the function, initializing some but not all of what it does normally. Previously this would stop the demuxer and trigger cleanup, after the change the code continues and may behave badly when it uses half initialized structures
ffmpeg-devel mailing list
ffmpeg-devel at ffmpeg.org
More information about the ffmpeg-devel