[FFmpeg-devel] [PATCH 2/5] lavc: replace and deprecate the lock manager

Michael Niedermayer michael at niedermayer.cc
Sat Dec 23 23:32:36 EET 2017


On Thu, Dec 21, 2017 at 11:22:21PM +0100, wm4 wrote:
> Use static mutexes instead of requiring a lock manager. The behavior
> should be roughly the same before and after this change for API users
> which did not set the lock manager at all (except that a minor memory
> leak disappears).
> ---
>  doc/APIchanges       |   5 +++
>  libavcodec/avcodec.h |   8 +++-
>  libavcodec/utils.c   | 107 +++++----------------------------------------------
>  libavcodec/version.h |   5 ++-
>  4 files changed, 26 insertions(+), 99 deletions(-)

Are all thread APIs users used with our lock manager compatible with this
replacement ?

Someone, possibly reimar, but i may misremember who it was. Talked in the past 
about thread API incompatibilies
I believe the concern was that the user APP used multiple threads, one for each
decoder and one for the demuxer. But the locking used by the user app between
its threads could be incompatible with the locking of our "pthread" locks.

If this is not an issue, then iam happy about this patch and the
removial of the lock manager complexity.

thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171223/bad26544/attachment.sig>


More information about the ffmpeg-devel mailing list