[FFmpeg-devel] [PATCH 2/6] mpeg: add experimental support for PSMF audio.

[Misty De Meo]

I originally left this patch alone since it was another person's
commit; I can squash the fixes for that into this commit if you
prefer, though.

On Tue, Dec 26, 2017 at 8:39 AM, Michael Niedermayer
<michael at niedermayer.cc> wrote:
> On Mon, Dec 25, 2017 at 10:28:30AM +0800, misty at brew.sh wrote:
>> From: Maxim Poliakovski <maximumspatium at googlemail.com>
>>
>> ---
>>  libavcodec/Makefile            |   1 +
>>  libavcodec/allcodecs.c         |   1 +
>>  libavcodec/atrac3plus_parser.c | 153 +++++++++++++++++++++++++++++++++++++++++
>>  libavformat/mpeg.c             |  27 +++++++-
>>  4 files changed, 181 insertions(+), 1 deletion(-)
>>  create mode 100644 libavcodec/atrac3plus_parser.c
>
> This fails to build without the next patch
>
> libavcodec/atrac3plus_parser.c: In function ‘parse_sound_frame_header’:
> libavcodec/atrac3plus_parser.c:41:22: error: ‘ff_oma_srate_tab’ undeclared (first use in this function)
>      c->sample_rate = ff_oma_srate_tab[(atrac_config >> 13) & 7] * 100;
>                       ^
> libavcodec/atrac3plus_parser.c:41:22: note: each undeclared identifier is reported only once for each function it appears in
> libavcodec/atrac3plus_parser.c: In function ‘ff_atrac3p_parse’:
> libavcodec/atrac3plus_parser.c:92:32: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘size_t’ [-Wformat=]
>                                 bytes_remain, buf_size);
>                                 ^
> libavcodec/atrac3plus_parser.c:123:27: error: ‘ff_oma_chid_to_num_channels’ undeclared (first use in this function)
>          avctx->channels       = ff_oma_chid_to_num_channels[ctx->channel_id - 1];
>                            ^
> libavcodec/atrac3plus_parser.c:124:33: error: ‘ff_oma_chid_to_native_layout’ undeclared (first use in this function)
>          avctx->channel_layout = ff_oma_chid_to_native_layout[ctx->channel_id - 1];
>                                  ^
> make: *** [libavcodec/atrac3plus_parser.o] Error 1
> make: *** Waiting for unfinished jobs....
>
> [...]
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> During times of universal deceit, telling the truth becomes a
> revolutionary act. -- George Orwell
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>