[FFmpeg-devel] [RFC][PATCH] simple_idct: Template functions to support an input bitdepth parameter

[Michael Niedermayer]

On Wed, Dec 27, 2017 at 01:11:56AM +0000, Kieran Kunhya wrote:
> For MPEG-4 Simple Studio Profile, I need to be able to support int32_t
> input coeffcients to the IDCT functions. I have attempted to implement this
> with the attached patch.
> Any comments would be appreciated, I'm pretty sure it is not optimal as-is.
> 
> Regards,
> Kieran Kunhya

>  bit_depth_template.c   |   17 ++++++++++++++++-
>  idctdsp.c              |   18 +++++++++---------
>  me_cmp.c               |    2 +-
>  simple_idct.c          |   15 ++++++++++++---
>  simple_idct.h          |   24 ++++++++++++++----------
>  simple_idct_template.c |   43 ++++++++++++++++++++++++++++---------------
>  vc1.c                  |    4 ++--
>  7 files changed, 82 insertions(+), 41 deletions(-)
> b69afd1419eafb71e999874a220369b08c01d931  0001-simple_idct-Template-functions-to-support-an-input-b.patch
> From 9675ff0714df15e433dbe78d6e40c2430c21b519 Mon Sep 17 00:00:00 2001
> From: Kieran Kunhya <kieran at kunhya.com>
> Date: Wed, 27 Dec 2017 01:08:39 +0000
> Subject: [PATCH] simple_idct: Template functions to support an input bitdepth
>  parameter

this breaks build of 
make distclean ; ./configure && make -j12  testprogs

CC	libavcodec/tests/dct.o
libavcodec/tests/dct.c:85:22: error: ‘ff_simple_idct_8’ undeclared here (not in a function)
     { "SIMPLE-C",    ff_simple_idct_8,     FF_IDCT_PERM_NONE },
                      ^
libavcodec/tests/dct.c:86:22: error: ‘ff_simple_idct_10’ undeclared here (not in a function)
     { "SIMPLE-C10",  ff_simple_idct_10,    FF_IDCT_PERM_NONE },
                      ^
libavcodec/tests/dct.c:87:22: error: ‘ff_simple_idct_12’ undeclared here (not in a function)
     { "SIMPLE-C12",  ff_simple_idct_12,    FF_IDCT_PERM_NONE, 0, 1 },
                      ^
make: *** [libavcodec/tests/dct.o] Error 1
make: Target `testprogs' not remade because of errors.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

"I am not trying to be anyone's saviour, I'm trying to think about the
 future and not be sad" - Elon Musk

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171227/d82c627a/attachment.sig>