[FFmpeg-devel] [PATCH 2/2] avformat/hls: use AVIOContext new_http_request callback

Nicolas George george at nsup.org
Sat Dec 30 00:45:10 EET 2017

Aman Gupta (2017-12-29):
> From: Aman Gupta <aman at tmm1.net>
> This fixes a segfault when streaming from an HLS playlist which uses
> crypto, by ensuring ff_http_do_new_request will never be invoked on a
> non-http URLContext.
> Additionally it simplifies the demuxer by removing http.h and all the
> http specific code in open_url_keepalive.

It it awfully specific for something quite minor. And it is messing with
the public API, that requires careful design.

I suggest to have ff_http_do_new_request() check that its argument is
really a HTTP context and return EINVAL or ENOSYS otherwise.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171229/e17ddbec/attachment.sig>

More information about the ffmpeg-devel mailing list