[FFmpeg-devel] [PATCH] Cinepak: speed up decoding several-fold, depending on the scenario, by supporting multiple output pixel formats.

Ronald S. Bultje rsbultje at gmail.com
Tue Feb 7 17:29:01 EET 2017


On Tue, Feb 7, 2017 at 9:57 AM, <u-9iep at aetey.se> wrote:

> Still, given the disapproval of the "code quality" without a tangible
> criteria to follow, I can hardly take any accomodating steps, barring
> the omission of the unused code - would this step be enough?

So, right now, the decoder outputs pal8 vs. rgb24 depending on the internal
format of the bitstream, and you're changing it to do conversion so it
outputs a selectable output format directly, right? (And then there's some
discussion over how to select the format.)

My personal opinion is that it's not worth it to do colorspace conversion
of any sort, including palette resolution, in a decoder. I understand using
swscale to do the conversion is slower, but cinepak is a fringe codec and a
new haswell i7 isn't that expensive. (Code maintenance has a cost also.)


More information about the ffmpeg-devel mailing list