[FFmpeg-devel] [PATCH] omx: Add support for specifying H.264 profile [v2']

Moritz Barsnick barsnick at gmx.net
Wed Feb 8 13:22:06 EET 2017

On Wed, Feb 08, 2017 at 11:12:12 +0100, Moritz Barsnick wrote:
> Your switch/case no longer has a default. Is that intended? (Code
> linters will complain.) AFAICT, avctx->profile will be unset if an
> unknown s->profile is given. Is that okay? (It might be - I'm just
> wondering. I *do* understand that not using the "profile" option will
> default s->profile to FF_PROFILE_H264_HIGH.)

D'uh, sorry about that comment. I just figured out: Your option code
doesn't allow anything else (for the time being) than the three named

Remark withdrawn, though adding a default *might* be safer.


More information about the ffmpeg-devel mailing list