[FFmpeg-devel] [PATCH] mov, matroskadec : Allow matroskadec & mov to share spherical parsing logic.
vittorio.giovara at gmail.com
Wed Feb 8 15:47:29 EET 2017
On Mon, Feb 6, 2017 at 4:59 PM, Aaron Colwell <acolwell at google.com> wrote:
> - Extracts common spherical metadata parsing logic.
> - Adds checks to enforce that only non-tiled equirect & non-padded cubemaps
> are accepted.
this patch basically ignores all my comments, so I'm not very happy with it.
I believe the biggest complaint of mine is that this implementation
only works with the ffmpeg command line and leaves users in the dark,
in addition to everything I said in the other thread. There are other
cosmetics oddities (such as adding a *mov* dependency to the
*matroska* code, or mixing code move with new functionality) which are
practices that should be avoided.
If you don't mind, I'll try to work on something that should finally
settle this and provide a patch.
More information about the ffmpeg-devel