[FFmpeg-devel] [PATCH] Implement optimal huffman encoding for (M)JPEG.

[Michael Niedermayer]

On Wed, Feb 01, 2017 at 11:23:04PM -0800, Jerry Jiang wrote:
> > seems to break
> > make fate-vsynth1-mjpeg-444
> 
> Fixed.
> 
> ---
>  Changelog                                        |   1 +
>  doc/encoders.texi                                |  21 ++
>  libavcodec/Makefile                              |   8 +-
>  libavcodec/mjpegenc.c                            | 243 +++++++++++++++++------
>  libavcodec/mjpegenc.h                            |  68 ++++++-
>  libavcodec/mjpegenc_common.c                     | 166 +++++++++++++++-
>  libavcodec/mjpegenc_common.h                     |   2 +
>  libavcodec/mjpegenc_huffman.c                    | 195 ++++++++++++++++++
>  libavcodec/mjpegenc_huffman.h                    |  74 +++++++
>  libavcodec/mpegvideo.h                           |   1 +
>  libavcodec/mpegvideo_enc.c                       |  17 +-
>  libavcodec/tests/.gitignore                      |   1 +
>  libavcodec/tests/mjpegenc_huffman.c              | 163 +++++++++++++++
>  tests/fate/libavcodec.mak                        |   6 +
>  tests/fate/vcodec.mak                            |  12 +-
>  tests/ref/vsynth/vsynth1-mjpeg-huffman           |   4 +
>  tests/ref/vsynth/vsynth1-mjpeg-trell-huffman     |   4 +
>  tests/ref/vsynth/vsynth2-mjpeg-huffman           |   4 +
>  tests/ref/vsynth/vsynth2-mjpeg-trell-huffman     |   4 +
>  tests/ref/vsynth/vsynth3-mjpeg-huffman           |   4 +
>  tests/ref/vsynth/vsynth3-mjpeg-trell-huffman     |   4 +
>  tests/ref/vsynth/vsynth_lena-mjpeg-huffman       |   4 +
>  tests/ref/vsynth/vsynth_lena-mjpeg-trell-huffman |   4 +
>  23 files changed, 914 insertions(+), 96 deletions(-)
>  create mode 100644 libavcodec/mjpegenc_huffman.c
>  create mode 100644 libavcodec/mjpegenc_huffman.h
>  create mode 100644 libavcodec/tests/mjpegenc_huffman.c
>  create mode 100644 tests/ref/vsynth/vsynth1-mjpeg-huffman
>  create mode 100644 tests/ref/vsynth/vsynth1-mjpeg-trell-huffman
>  create mode 100644 tests/ref/vsynth/vsynth2-mjpeg-huffman
>  create mode 100644 tests/ref/vsynth/vsynth2-mjpeg-trell-huffman
>  create mode 100644 tests/ref/vsynth/vsynth3-mjpeg-huffman
>  create mode 100644 tests/ref/vsynth/vsynth3-mjpeg-trell-huffman
>  create mode 100644 tests/ref/vsynth/vsynth_lena-mjpeg-huffman
>  create mode 100644 tests/ref/vsynth/vsynth_lena-mjpeg-trell-huffman

i somehow must have missed this patch resubmission

this breaks *jpeg slice multithreading

./ffmpeg  -i lena.pnm -threads 4 -thread_type slice file.jpg

result is just a green image and errors

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170209/5cc68273/attachment.sig>