[FFmpeg-devel] [PATCH] nvenc: FIX wrong forced keyframe behavior

[Miroslav Slugeň]

Dne 12.2.2017 v 21:01 Timo Rothenpieler napsal(a):
> On 2/12/2017 8:56 PM, Miroslav Slugeň wrote:
>>>> 2. We should change it in libx264 and libx265
>>> Changing it in nvenc now would be kind of an API break, as the behaviour
>>> might change without someone expecting it.
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel at ffmpeg.org
>>> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>> I don't think so, onlything is changed is when you forcing keyframes
>> with -forced_keyframes option it was not working in NVENC without
>> specifiing -force_idr 0 or 1, is there any other situation when some
>> parts of ffmpeg will force key frames and NVENC naturaly ignore them?
> It's primarily a concern with API users which might set the pict_type.
> Probably does not affect any notable amount of users.
> Might as well remove -1 as a supported value from the option then.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
I checked libx264 and there is -1 option, so i think it should stay 
there also for future use (like automatic IDR/INTRA decisions). But it 
could be removed also.

M.