[FFmpeg-devel] [PATCH] doc/hlsenc: hls_segment_filename, use_localtime, , use_localtime_mkdir, hls_flags

Moritz Barsnick barsnick at gmx.net
Mon Jan 2 14:54:07 EET 2017


On Mon, Jan 02, 2017 at 12:49:50 +0100, Bodecs Bela wrote:
> Subject: [FFmpeg-devel] [PATCH] doc/hlsenc: hls_segment_filename, use_localtime, , use_localtime_mkdir, hls_flags
                                                                                   ^^
There's a ", " too much in that part of the commit message.

> + at var{filename} may contain full path or relative path specification, but only the file name part without any path info will be contained in the m3u8 segment list.

You should break this line.

> +Should relative path is specified, path of created segment files will be relative to the current working directory.

-> 
  Should a relative path be specified, the path of the created segment
  files will be relative to the current working directory.

> +When -use_localtime_mkdir is set, the whole expanded value of @var{filename} will be written into m3u8 segment list.
        ^ I think you should omit the dashes, as these are primarily
          library options, not command line options.

And do add an article: "...  will be written into the m3u8 segment
list."

> - at file{file-20160215-1455569023.ts}, @file{file-20160215-1455569024.ts}, etc.
> + at file{file-20160215-1455569023.ts}, @file{file-20160215-1455569024.ts}, etc. (Notice: in some systems/environments %s specifier is not available. See strftime() documentation!)

->
  Note: On some systems/environments, the code{%s} specifier is not available. See
  code{strftime()} documentation.

(Avoid exclamation marks.)

> +This example will create a directory hierarchy 2016/02/15 (if any of them does not exist), and then
                                                                             ^ do

Moritz


More information about the ffmpeg-devel mailing list